{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":353494486,"defaultBranch":"master","name":"ironfish","ownerLogin":"iron-fish","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-03-31T21:26:37.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/43299557?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1721431483.0","currentOid":""},"activityList":{"items":[{"before":"240eac6d12590dc0459fa705ec1311dd02b53907","after":"97d1c38d83bd0f7d28a6ab37a5f5b4852afd56c6","ref":"refs/heads/add-all-functions-to-global-contract","pushedAt":"2024-07-20T05:53:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danield9tqh","name":"Daniel Cogan","path":"/danield9tqh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4173815?s=80&v=4"},"commit":{"message":"fix global contract json","shortMessageHtmlLink":"fix global contract json"}},{"before":"8536c0ae51547d2236c6399f4d9be91f12f2dff5","after":"240eac6d12590dc0459fa705ec1311dd02b53907","ref":"refs/heads/add-all-functions-to-global-contract","pushedAt":"2024-07-20T05:42:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"danield9tqh","name":"Daniel Cogan","path":"/danield9tqh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4173815?s=80&v=4"},"commit":{"message":"Fix lint","shortMessageHtmlLink":"Fix lint"}},{"before":"500362aafce022dfc67de664ba4ccaffe204334e","after":"8536c0ae51547d2236c6399f4d9be91f12f2dff5","ref":"refs/heads/add-all-functions-to-global-contract","pushedAt":"2024-07-20T05:33:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danield9tqh","name":"Daniel Cogan","path":"/danield9tqh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4173815?s=80&v=4"},"commit":{"message":"Fix lint","shortMessageHtmlLink":"Fix lint"}},{"before":"1108e4775ed4082f78a3a1d62e04c1c007d45b71","after":null,"ref":"refs/heads/rahul/refactor-evm-instantiation","pushedAt":"2024-07-19T23:24:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"patnir","name":"Rahul Patni","path":"/patnir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13268167?s=80&v=4"}},{"before":"280ca29e27c7174f9678b82ea34e162ba5a38565","after":"c23d45cd1e5c5853f8f664fadc097765e2f7aa00","ref":"refs/heads/evm","pushedAt":"2024-07-19T23:24:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"patnir","name":"Rahul Patni","path":"/patnir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13268167?s=80&v=4"},"commit":{"message":"Changes how EVM is instantiated. (#5157)\n\n* Changes how EVM is instantiated.\r\n\r\nPreviously, we needed to check whether the EVM on the blockchain object was instantiated.\r\nThere shouldn't be a case where EVM is not instantiated. We should always have an EVM instance.\r\n\r\nThat change was made because instantiating EVM requires async code because of the VM instantiation.\r\n\r\nThis change changes that pattern to a synchronous instantiation. The VM instantiation now happens in the open function that is no longer static.\r\nWe check whether the object has been instantiated in the sub functions of the EVM class.\r\n\r\n* updates cli commands with this change","shortMessageHtmlLink":"Changes how EVM is instantiated. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2419842125\" data-permission-text=\"Title is private\" data-url=\"https://github.com/iron-fish/ironfish/issues/5157\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/iron-fish/ironfish/pull/5157/hovercard\" href=\"https://github.com/iron-fish/ironfish/pull/5157\">#5157</a>)"}},{"before":null,"after":"af3bf119f12af7e9ced199a739037e6173030be9","ref":"refs/heads/jason/cmd-desc","pushedAt":"2024-07-19T23:20:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"NullSoldier","name":"Jason Spafford","path":"/NullSoldier","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/458976?s=80&v=4"},"commit":{"message":"Adjust descriptions of chain commands","shortMessageHtmlLink":"Adjust descriptions of chain commands"}},{"before":"331245ff7d12e902cbe66889deb150066b6b205c","after":"e56ea87dafda40d1cce1d2f54367f34096229dc2","ref":"refs/heads/unshield-verification-of-burns","pushedAt":"2024-07-19T21:30:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"},"commit":{"message":"remove unneeded comment","shortMessageHtmlLink":"remove unneeded comment"}},{"before":"db7ac9c8d9f3cc23346cfb14b1da5d7f2b1f2ab0","after":"331245ff7d12e902cbe66889deb150066b6b205c","ref":"refs/heads/unshield-verification-of-burns","pushedAt":"2024-07-19T21:28:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"},"commit":{"message":"remove unneeded comment","shortMessageHtmlLink":"remove unneeded comment"}},{"before":"7e58e17bb53783296b8b63bb03ba37719a43b8bf","after":"db7ac9c8d9f3cc23346cfb14b1da5d7f2b1f2ab0","ref":"refs/heads/unshield-verification-of-burns","pushedAt":"2024-07-19T21:24:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"},"commit":{"message":"verifier update based on pr comments from shield/mint","shortMessageHtmlLink":"verifier update based on pr comments from shield/mint"}},{"before":"57943383b5d8d97bd3ce920aba756aaeeb8ddfa2","after":null,"ref":"refs/heads/shield-verification-of-mints","pushedAt":"2024-07-19T21:23:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"}},{"before":"c3ba4ec4b74cf4a242b1b1f717545b67d420873d","after":"280ca29e27c7174f9678b82ea34e162ba5a38565","ref":"refs/heads/evm","pushedAt":"2024-07-19T21:23:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"},"commit":{"message":"Shield verification of mints  (#5142)\n\n* adds shield verification for custom assets, does NOT add verification for native asset\r\n\r\n* pr comment cleanup","shortMessageHtmlLink":"Shield verification of mints (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2417164739\" data-permission-text=\"Title is private\" data-url=\"https://github.com/iron-fish/ironfish/issues/5142\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/iron-fish/ironfish/pull/5142/hovercard\" href=\"https://github.com/iron-fish/ironfish/pull/5142\">#5142</a>)"}},{"before":"87a714c7b119aff4cccc7d7243b058d300c6e859","after":null,"ref":"refs/heads/wip/manager-build-block","pushedAt":"2024-07-19T21:22:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hughy","name":"Hugh Cunningham","path":"/hughy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/57735705?s=80&v=4"}},{"before":"618940244f288f2e85b09367f93b35cc4beef987","after":"c3ba4ec4b74cf4a242b1b1f717545b67d420873d","ref":"refs/heads/evm","pushedAt":"2024-07-19T21:22:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hughy","name":"Hugh Cunningham","path":"/hughy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/57735705?s=80&v=4"},"commit":{"message":"manager verifies evm transactions during template construction (#5155)\n\nas the mining manager takes transactions from the mempool during block template\r\nconstruction it performs some basic verification and skips any invalid\r\ntransactions. this prevents the mining manager from getting stuck producing\r\ntemplates that include invalid transactions\r\n\r\neach evm transaction in the mempool is verified individually, but may be invalid\r\nwhen sequenced after another evm transaction. for instance, if a later\r\ntransaction uses the same nonce as an earlier transaction, or if it causes an\r\ninsufficient funds error after an earlier transaction is executed.\r\n\r\nadds logic to getNewBlockTransactions to call verifyEvm on each evm transaction\r\ntaken from the mempool to avoid invalid evm transactions\r\n\r\nuses withCopy to prevent database commits from evm transaction execution.\r\ntransactions are still executed in Blockchain.newBlock, so we should avoid state\r\nupdates to prevent transactions being invalid on the second execution\r\n\r\nin the future we might look at refactoring block template construction and\r\nBlockchain.newBlock to avoid unnecessarily executing evm transactions multiple\r\ntimes, but for the spike it's not necessary to optimize","shortMessageHtmlLink":"manager verifies evm transactions during template construction (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2419647607\" data-permission-text=\"Title is private\" data-url=\"https://github.com/iron-fish/ironfish/issues/5155\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/iron-fish/ironfish/pull/5155/hovercard\" href=\"https://github.com/iron-fish/ironfish/pull/5155\">#5155</a>)"}},{"before":"293cfdd6f1b384146265a4ac85db37659a892ab8","after":null,"ref":"refs/heads/mat/tx-info","pushedAt":"2024-07-19T21:17:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"NullSoldier","name":"Jason Spafford","path":"/NullSoldier","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/458976?s=80&v=4"}},{"before":"d021340d7f2350da726368f13fd61d846adc9d0a","after":"cf0704bb4f776da5f9e77c94bbe2998f30b69694","ref":"refs/heads/staging","pushedAt":"2024-07-19T21:17:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"NullSoldier","name":"Jason Spafford","path":"/NullSoldier","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/458976?s=80&v=4"},"commit":{"message":"Add `chain:transactions:info` command (#5149)\n\n* Add `chain:transactions:info` command\r\n\r\n* Use new ui card element","shortMessageHtmlLink":"Add <code>chain:transactions:info</code> command (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2417506093\" data-permission-text=\"Title is private\" data-url=\"https://github.com/iron-fish/ironfish/issues/5149\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/iron-fish/ironfish/pull/5149/hovercard\" href=\"https://github.com/iron-fish/ironfish/pull/5149\">#5149</a>)"}},{"before":"eee1c05d501eedac845ccda56acfa4f1ae5468ff","after":null,"ref":"refs/heads/jason/chain-status","pushedAt":"2024-07-19T21:02:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"NullSoldier","name":"Jason Spafford","path":"/NullSoldier","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/458976?s=80&v=4"}},{"before":"0a3187f539a1d63e8004ca851d42879123a4b97e","after":"d021340d7f2350da726368f13fd61d846adc9d0a","ref":"refs/heads/staging","pushedAt":"2024-07-19T21:02:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"NullSoldier","name":"Jason Spafford","path":"/NullSoldier","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/458976?s=80&v=4"},"commit":{"message":"Add chain:status command (#5150)\n\nThis new command shows more detailed information specifically about the\r\nblockchain than is shown by node status.","shortMessageHtmlLink":"Add chain:status command (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2417527628\" data-permission-text=\"Title is private\" data-url=\"https://github.com/iron-fish/ironfish/issues/5150\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/iron-fish/ironfish/pull/5150/hovercard\" href=\"https://github.com/iron-fish/ironfish/pull/5150\">#5150</a>)"}},{"before":"456bd48140e739a5d2d209869cd1988f95c08b35","after":"293cfdd6f1b384146265a4ac85db37659a892ab8","ref":"refs/heads/mat/tx-info","pushedAt":"2024-07-19T20:56:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mat-if","name":null,"path":"/mat-if","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/97762857?s=80&v=4"},"commit":{"message":"Use new ui card element","shortMessageHtmlLink":"Use new ui card element"}},{"before":"ae9e9aa448d5c53b02fb81829e17e4190aaafde2","after":"1108e4775ed4082f78a3a1d62e04c1c007d45b71","ref":"refs/heads/rahul/refactor-evm-instantiation","pushedAt":"2024-07-19T20:56:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"patnir","name":"Rahul Patni","path":"/patnir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13268167?s=80&v=4"},"commit":{"message":"updates cli commands with this change","shortMessageHtmlLink":"updates cli commands with this change"}},{"before":"b530842345cf5b92bf0b13c1e211cbad01d3332a","after":"456bd48140e739a5d2d209869cd1988f95c08b35","ref":"refs/heads/mat/tx-info","pushedAt":"2024-07-19T20:56:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mat-if","name":null,"path":"/mat-if","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/97762857?s=80&v=4"},"commit":{"message":"Use new ui card element","shortMessageHtmlLink":"Use new ui card element"}},{"before":null,"after":"ae9e9aa448d5c53b02fb81829e17e4190aaafde2","ref":"refs/heads/rahul/refactor-evm-instantiation","pushedAt":"2024-07-19T20:54:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"patnir","name":"Rahul Patni","path":"/patnir","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13268167?s=80&v=4"},"commit":{"message":"Changes how EVM is instantiated.\n\nPreviously, we needed to check whether the EVM on the blockchain object was instantiated.\nThere shouldn't be a case where EVM is not instantiated. We should always have an EVM instance.\n\nThat change was made because instantiating EVM requires async code because of the VM instantiation.\n\nThis change changes that pattern to a synchronous instantiation. The VM instantiation now happens in the open function that is no longer static.\nWe check whether the object has been instantiated in the sub functions of the EVM class.","shortMessageHtmlLink":"Changes how EVM is instantiated."}},{"before":"c9162fbc557877dbe93a3901cc15c9e80fb569f4","after":"7e58e17bb53783296b8b63bb03ba37719a43b8bf","ref":"refs/heads/unshield-verification-of-burns","pushedAt":"2024-07-19T20:35:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"},"commit":{"message":"verifier update based on pr comments from shield/mint","shortMessageHtmlLink":"verifier update based on pr comments from shield/mint"}},{"before":null,"after":"500362aafce022dfc67de664ba4ccaffe204334e","ref":"refs/heads/add-all-functions-to-global-contract","pushedAt":"2024-07-19T20:16:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"danield9tqh","name":"Daniel Cogan","path":"/danield9tqh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4173815?s=80&v=4"},"commit":{"message":"WIP","shortMessageHtmlLink":"WIP"}},{"before":"b8aa8b05ecbddeaca9769311e05c71635a6e0f38","after":"36e407aaa6e6f6bac93f998f83eae61bdcf3ec23","ref":"refs/heads/add-build-for-contracts-package","pushedAt":"2024-07-19T20:10:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danield9tqh","name":"Daniel Cogan","path":"/danield9tqh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4173815?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"24676fb83ffc4cf7ceaff30311e8ca7c3c6c427d","after":"b8aa8b05ecbddeaca9769311e05c71635a6e0f38","ref":"refs/heads/add-build-for-contracts-package","pushedAt":"2024-07-19T20:09:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danield9tqh","name":"Daniel Cogan","path":"/danield9tqh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4173815?s=80&v=4"},"commit":{"message":"Fix lint and tests","shortMessageHtmlLink":"Fix lint and tests"}},{"before":"16efbf50aefee52e0a1552f3c45ae7091f73f542","after":"c9162fbc557877dbe93a3901cc15c9e80fb569f4","ref":"refs/heads/unshield-verification-of-burns","pushedAt":"2024-07-19T20:03:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"},"commit":{"message":"verifier update based on pr comments from shield/mint","shortMessageHtmlLink":"verifier update based on pr comments from shield/mint"}},{"before":"426130aab8c26443b193e56f135dd5fd38f7c9b4","after":"57943383b5d8d97bd3ce920aba756aaeeb8ddfa2","ref":"refs/heads/shield-verification-of-mints","pushedAt":"2024-07-19T20:01:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"},"commit":{"message":"pr comment cleanup","shortMessageHtmlLink":"pr comment cleanup"}},{"before":"2f41609eaf40956d25b9f7bf038c371a7dee771a","after":"16efbf50aefee52e0a1552f3c45ae7091f73f542","ref":"refs/heads/unshield-verification-of-burns","pushedAt":"2024-07-19T19:38:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"},"commit":{"message":"verifier update based on pr comments from shield/mint","shortMessageHtmlLink":"verifier update based on pr comments from shield/mint"}},{"before":"07291c7c96c2d20d9062b257a71178c00d006e20","after":"426130aab8c26443b193e56f135dd5fd38f7c9b4","ref":"refs/heads/shield-verification-of-mints","pushedAt":"2024-07-19T19:34:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jowparks","name":null,"path":"/jowparks","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/26990067?s=80&v=4"},"commit":{"message":"pr comment cleanup","shortMessageHtmlLink":"pr comment cleanup"}},{"before":null,"after":"87a714c7b119aff4cccc7d7243b058d300c6e859","ref":"refs/heads/wip/manager-build-block","pushedAt":"2024-07-19T19:01:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hughy","name":"Hugh Cunningham","path":"/hughy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/57735705?s=80&v=4"},"commit":{"message":"manager verifies evm transactions during template construction\n\nas the mining manager takes transactions from the mempool during block template\nconstruction it performs some basic verification and skips any invalid\ntransactions. this prevents the mining manager from getting stuck producing\ntemplates that include invalid transactions\n\neach evm transaction in the mempool is verified individually, but may be invalid\nwhen sequenced after another evm transaction. for instance, if a later\ntransaction uses the same nonce as an earlier transaction, or if it causes an\ninsufficient funds error after an earlier transaction is executed.\n\nadds logic to getNewBlockTransactions to call verifyEvm on each evm transaction\ntaken from the mempool to avoid invalid evm transactions\n\nuses withCopy to prevent database commits from evm transaction execution.\ntransactions are still executed in Blockchain.newBlock, so we should avoid state\nupdates to prevent transactions being invalid on the second execution\n\nin the future we might look at refactoring block template construction and\nBlockchain.newBlock to avoid unnecessarily executing evm transactions multiple\ntimes, but for the spike it's not necessary to optimize","shortMessageHtmlLink":"manager verifies evm transactions during template construction"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEhHSz4QA","startCursor":null,"endCursor":null}},"title":"Activity · iron-fish/ironfish"}