Basic Functionality #1

Merged
merged 6 commits into from Jul 8, 2012

Conversation

Projects
None yet
2 participants
@odeits
Contributor

odeits commented May 22, 2012

All test pass. To include in a project build IronCache then copy all DLLs to your project's /bin directory.
This should be considered BETA only.

@edsrzf

This comment has been minimized.

Show comment Hide comment
@edsrzf

edsrzf Jun 25, 2012

Contributor

First: sorry this took so long. There's no excuse. It just slipped my mind and I was reminded of it today for some reason. Thank you for writing this.

Second, the code looks great, although I would like to see the design resemble other clients a little bit more. Specifically I would like to see a separate Cache class that has most of the methods (Put, Get, Delete, etc.). You might also consider having separate Add and Replace methods rather than making them arguments to Put.

If you want someone else to make the suggested changes, that's fine too. We appreciate the work you've put into this.

Contributor

edsrzf commented Jun 25, 2012

First: sorry this took so long. There's no excuse. It just slipped my mind and I was reminded of it today for some reason. Thank you for writing this.

Second, the code looks great, although I would like to see the design resemble other clients a little bit more. Specifically I would like to see a separate Cache class that has most of the methods (Put, Get, Delete, etc.). You might also consider having separate Add and Replace methods rather than making them arguments to Put.

If you want someone else to make the suggested changes, that's fine too. We appreciate the work you've put into this.

@odeits

This comment has been minimized.

Show comment Hide comment
@odeits

odeits Jun 25, 2012

Contributor

Thank you for getting back to me. I was planning on making those
improvements but wanted a review first. There was some issue with the
naming of values we had talked about and I don't know where that is at this
point. I will be happy to continue to contribute to this project.

Regards,
Oscar Deits
www.onlinesheetmusic.com

On Mon, Jun 25, 2012 at 1:23 PM, Evan Shaw <
reply@reply.github.com

wrote:

First: sorry this took so long. There's no excuse. It just slipped my mind
and I was reminded of it today for some reason. Thank you for writing this.

Second, the code looks great, although I would like to see the design
resemble other clients a little bit more. Specifically I would like to see
a separate Cache class that has most of the methods (Put, Get, Delete,
etc.). You might also consider having separate Add and Replace methods
rather than making them arguments to Put.

If you want someone else to make the suggested changes, that's fine too.
We appreciate the work you've put into this.


Reply to this email directly or view it on GitHub:
#1 (comment)

Contributor

odeits commented Jun 25, 2012

Thank you for getting back to me. I was planning on making those
improvements but wanted a review first. There was some issue with the
naming of values we had talked about and I don't know where that is at this
point. I will be happy to continue to contribute to this project.

Regards,
Oscar Deits
www.onlinesheetmusic.com

On Mon, Jun 25, 2012 at 1:23 PM, Evan Shaw <
reply@reply.github.com

wrote:

First: sorry this took so long. There's no excuse. It just slipped my mind
and I was reminded of it today for some reason. Thank you for writing this.

Second, the code looks great, although I would like to see the design
resemble other clients a little bit more. Specifically I would like to see
a separate Cache class that has most of the methods (Put, Get, Delete,
etc.). You might also consider having separate Add and Replace methods
rather than making them arguments to Put.

If you want someone else to make the suggested changes, that's fine too.
We appreciate the work you've put into this.


Reply to this email directly or view it on GitHub:
#1 (comment)

@edsrzf

This comment has been minimized.

Show comment Hide comment
@edsrzf

edsrzf Jun 25, 2012

Contributor

I think the issue of the name "value" vs. "body" was only in the documentation. That is, I found that the actual software was consistently using "value" everywhere. (If you find a place where that's not true, please let me know.) The documentation has been fixed.

Contributor

edsrzf commented Jun 25, 2012

I think the issue of the name "value" vs. "body" was only in the documentation. That is, I found that the actual software was consistently using "value" everywhere. (If you find a place where that's not true, please let me know.) The documentation has been fixed.

@odeits

This comment has been minimized.

Show comment Hide comment
@odeits

odeits Jul 4, 2012

Contributor

There funtions Add, Set, Replace are exposed that call put with the correct arguments. I did it this way because add:true + replace:true is invalid.

Contributor

odeits commented Jul 4, 2012

There funtions Add, Set, Replace are exposed that call put with the correct arguments. I did it this way because add:true + replace:true is invalid.

@edsrzf

This comment has been minimized.

Show comment Hide comment
@edsrzf

edsrzf Jul 8, 2012

Contributor

Looking good now. I think I'd make IronCache.Put private, but that's pretty minor. I'm willing to merge as is. Thanks a lot!

Contributor

edsrzf commented Jul 8, 2012

Looking good now. I think I'd make IronCache.Put private, but that's pretty minor. I'm willing to merge as is. Thanks a lot!

edsrzf added a commit that referenced this pull request Jul 8, 2012

@edsrzf edsrzf merged commit 483bcd1 into iron-io:master Jul 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment