Request a list of tasks with params #41
Conversation
| out := map[string][]TaskInfo{} | ||
| url := w.tasks() | ||
|
|
||
| if params.CodeName != "" { |
There was a problem hiding this comment.
This looks like code_name parameter, represented by TaskListParams.CodeName, is optional API parameter. Could you please remove the check, that CodeName is empty, and keep just url.QueryAdd(...).
There was a problem hiding this comment.
I just don't want an empty parameter to be included in the request. That's why I check for emptyness. The request will be fired even if it's empty. I can still remove it though.
By the way, according to the documentation (http://dev.iron.io/worker/reference/api/#list_tasks), it's a required parameter.
There was a problem hiding this comment.
I just don't want an empty parameter to be included in the request.
what's wrong with empty parameters in request? It is regular case for HTTP. Let worker's API handle all the errors ( ;
it's a required parameter
exactly. But in the client library it looks like optional.
Request a list of tasks with params
|
Thanks, @phacops ! |
This new method allows to send a request with different params to iron.io's API in order to filter what is returned.