Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

ib_conn_t struct leaking in webserver plugins #19

Closed
niq opened this Issue · 3 comments

3 participants

@niq
niq commented

This appears to affect both httpd and trafficserver plugins. Looks like low-hanging fruit I can easily fix.

An ib_conn_t struct is created for every connection, but never destroyed:

==1888== at 0x4C26FDE: malloc (vg_replace_malloc.c:236)
==1888== by 0xEA56939: ib_mpool_create_ex (mpool.c:90)
==1888== by 0xE8413BB: ib_conn_create (engine.c:381)
==1888== by 0xEC609FC: ironbee_plugin (ironbee.c:449)

@niq

Turns out this isn't the simple matter of adding ib_conn_destroy I supposed when this first showed up. That happens already in ib_state_notify_conn_closed. Evidently this is a deeper problem.

@b1v1r
Collaborator

Yep. Just need to call ib_conn_destroy() after ib_state_notify_conn_closed() in the plugins. Please fix.

(Nevermind - just saw your other comment, which never got emailed to me)

@b1v1r b1v1r was assigned
@ironbee
Owner

With major recent changes to mpool code all mem leaks will be investigated as a task

@ironbee ironbee closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.