New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwalitee score improvements #7

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@gryphonshafer

gryphonshafer commented Mar 13, 2015

I'm participating in the CPAN Pull Request initiative (http://cpan-prc.org), and I was assigned your module for March. After having reviewed it, I wasn't really sure what I could to do help improve it. So I made some tiny changes to raise the Kwalitee score. I've run the test suite and a few test scripts, and I don't think I've broken anything. I hope this was at least slightly helpful.

@ironcamel

This comment has been minimized.

Owner

ironcamel commented Jun 7, 2015

Thanks for this @gryphonshafer . Sorry for taking so long to respond. I will merge this PR as soon as I get a chance to sanity check all of your changes. Thanks!

@mjg17

This comment has been minimized.

mjg17 commented May 25, 2017

These changes look sane to me.
Cheers
Michael

@ironcamel

This comment has been minimized.

Owner

ironcamel commented Jun 5, 2017

I would like to merge this, but github is saying this branch has conflicts that must be resolved.

@gryphonshafer

This comment has been minimized.

gryphonshafer commented Jun 28, 2017

I'd love to help, but I'm too over-allocated. Given how much time has passed, it's probably better to just drop the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment