ironfroggy

  • Joined on

Organizations

@pantechnoco @caktus @s-a-s-forks
ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

Then I would suggest a two phase solution 1. Push this API branch through without the validation or publishing steps 2. Follow up with additional A…

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

What I suggest is to look at this validation not as a component of resource creation but a part of the life cycle. What we've been describing is a …

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

It begins to seem like validation has to be some specific action taken on a resource, rather than a rule simply applied at creation.

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

How does this need to validate the types or even contents of files mesh with the need to allow those files be modified? What happens to the validat…

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

Can someone briefly outline the nature of the sort of validation you need to do?

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

Yes the usual thing to do in a form is to set it to YourModel.objects.none() in the class definition and then do self.fields[fieldname].choices = Y…

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

You specifically named the size of the file. Does that mean the main concern is storage costs? And I'm not necessarily saying to never allow modifi…

@ironfroggy

I would recommend looking into a solution that utilizes the X-Sendfile header to pass the instruction along to the webserver directly to handle the…

@ironfroggy

The view for download does not check permissions in anyway. It also reads the entire file contents into memory before responding. This is extremely…

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

Good catch @selimnairb @pkdash did you and Brian discuss any of this in the call today (the one I missed)?

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

However, why the change from a multi-value field to a comma separated one?

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

That's a good direction yes

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

I agree.

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

The code where you set error_message is only executed in an except block that handles exceptions from creation of resource. You should never allow c…

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

If there are any files they should be consider invalid data and should cause a validation error response, I think.

ironfroggy commented on pull request hydroshare/hydroshare#313
@ironfroggy

There is a lot of condensed discussion here. Are the agreements and resolutions clear? In this first API branch, is PUT support required at all? C…

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

OK, based on point 1 here the ownership being revoked means that giving special permission here to the creator is, in fact, not a desired feature. …

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

What i'm questioning isn't showing one or all but calling them "author" in one place and "owner" in another.

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

the correct entity is  

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

What side effect are you considering? A del that removes a name right before the end of a function, when the name is about to leave scope anyway, i…

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

The problem is that an except: without any specific exception class will catch things like MemoryError and the exceptions that are raised when a pr…

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

I'm saying is there some place you can put the HSAccess object and store it for the length of the request you're handling? Maybe it could be a prop…

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

no need to close these at the end of a process, they'll be closed in garbage collection anyway.

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

these should be named

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

why is this migration tool not using the ORM to talk to the Django DB?

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

is this related to HSAccess integration?

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

how is all this related to adding HSAccess?

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

bare except

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

bare except

ironfroggy commented on pull request hydroshare/hydroshare#325
@ironfroggy

bare except