Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDTheme not applied on UDCard #529

Closed
itfranck opened this issue Jan 2, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@itfranck
Copy link
Contributor

commented Jan 2, 2019

The UDTheme values are not applied to UDCard.
See below.


$Theme = Get-UDTheme 'Azure'

$Dash = New-UDDashboard -Title 'test' -Theme $Theme -Content {
    New-UDCard -Title 'Broken' -Text 'Theme' 
    New-UDCard -Title 'UDCard Definition' -text "$($Theme.Definition.UDCard | Out-String)"
}


Start-UDDashboard  -Dashboard $Dash -Port 8888 

(Using v 2.2)

It looks like it happened before in : #310

Edit:
Looking in the console, it appears that there's a hard-coded style element for the ud-card class which overrides the theme.

<div class="card  ud-card" id="795f9cf0-738f-4a72-ae12-74ea19a6b064" style="background-color: rgb(255, 255, 255); color: rgb(0, 0, 0);">

Edit 2:
I added a pull request to remove the culprit style, which comes from the card.ps1 : #531

itfranck added a commit to itfranck/universal-dashboard that referenced this issue Jan 2, 2019

Removed forced style on udcard - ironmansoftware#529
udtheme  was never applied to UDCard as a predefined Style overrided the CSS.

itfranck added a commit to itfranck/universal-dashboard that referenced this issue Jan 2, 2019

adamdriscoll added a commit that referenced this issue Jan 2, 2019

Removed forced style on udcard - #529 (#531)
udtheme  was never applied to UDCard as a predefined Style overrided the CSS.

@adamdriscoll adamdriscoll added this to the 3.0.0 milestone Jan 2, 2019

@adamdriscoll adamdriscoll modified the milestones: 3.0.0, 2.2.1 Jan 9, 2019

@adamdriscoll adamdriscoll added the bug label Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.