Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4-beta1: code_fork icon throws an error #768

Closed
BlueArcherX opened this issue May 4, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@BlueArcherX
Copy link

commented May 4, 2019

Using: New-UDLink -Text "foo" -Url "https://foo.bar" -Icon 'code_fork'

New-UDLink : Cannot bind parameter 'Icon'. Cannot convert value "code_fork" to type "UniversalDashboard.Models.FontAwesomeIcons". Error: "Unable to match the identifier name code_fork to a valid enumerator name. Specify one of the following enumerator names and try again.

This was working in 2.3, and from looking through the list of options, it appears maybe this is referred to as code_branch in 2.4 instead, which may be causing the problem.

It is titled code-fork on FA4.7 as well, and there is no icon named code-branch.

@adamdriscoll

This comment has been minimized.

Copy link
Member

commented May 4, 2019

I need to fix this. The problem is that we moved to the new FA 5 library but there are a lot of icons that changed class names. I might roll back the change for now until I come up with a better solution.

@adamdriscoll adamdriscoll added the bug label May 4, 2019

@BlueArcherX

This comment has been minimized.

Copy link
Author

commented May 4, 2019

I see. The only reason I mentioned FA4.7 was because the .js file that is loaded on my dashboard in 2.4 still shows FA4.7. I poked around the other .js files to make sure I wans't missing something, but did not see any FA5 things. But feel free to smack me in the head if I am being blind!

D:<user>\Documents\PowerShell\Modules\UniversalDashboard.Community\2.4.0\client\vendors~font-awesome.1861f16e5bc27dc9f74f.bundle.js

contains:
// module
exports.push([module.i, "/*!\n * Font Awesome 4.7.0 by davegandy - http://fontawesome.io - fontawesome\n *

EDIT: Untagged Dave Gandy and Fontawesome since the code had @

@adamdriscoll

This comment has been minimized.

Copy link
Member

commented May 4, 2019

It looks like we had both packages included in this beta1 release. Double-ugh. Explains why the package size is larger. ;)

@adamdriscoll adamdriscoll added this to the 2.4 milestone May 8, 2019

@adamdriscoll

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Just merged a PR that supports backwards compat for 4.7 icon names and maps them to the 5.0 FA icon equivalents. I also completely removed the 4.7 package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.