Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi currencies per Brand #834

Merged
merged 8 commits into from Dec 27, 2018
Merged

Conversation

Kaian
Copy link
Member

@Kaian Kaian commented Dec 21, 2018

This PR allows configuring the currency symbol for each:

  • Brand (default currency for all its items)
  • Client
  • Carrier
  • Destination rate
  • Rating plan

Important notes:

  • Rating plans should only group destination rates using its currency.

  • Clients and carriers should only use rating plans using its currency.

    • Balance movements will be done using their currency.
    • Invoices will use client's currency.
    • Invoices' fixed costs will use client's currency.
  • Some backend checks avoid some of previous misconfigurations, but not all of them: use this feature carefully.

  • There is no currency conversion involved.

    • Call cost will be calculated in carrier's currency.
    • Call price will be calculated in client's currency.
  • LCR routes involving carriers with different currencies are not supported.

This PR fixes #636

@Kaian Kaian added billing Billing and Invoices schema Database changes core Core Libraries web/admin Administrator Portal * artemis * IvozProvider 2.x Artemis Release labels Dec 21, 2018
@Kaian Kaian added this to the 2.9 milestone Dec 21, 2018
@Kaian Kaian self-assigned this Dec 21, 2018
@Kaian Kaian changed the title Add support to multi-currency clients Add support for multi currencies per Brand Dec 21, 2018
@Kaian Kaian force-pushed the currency-symbols branch 4 times, most recently from 6d9af63 to 6f06603 Compare December 26, 2018 11:17
@Kaian Kaian merged commit cf676df into bleeding Dec 27, 2018
@Kaian Kaian deleted the currency-symbols branch December 27, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
* artemis * IvozProvider 2.x Artemis Release billing Billing and Invoices core Core Libraries schema Database changes web/admin Administrator Portal
Development

Successfully merging this pull request may close these issues.

Change default currency globally
2 participants