New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-botcmd only works on small channels #175

Closed
madduck opened this Issue Nov 11, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@madduck

madduck commented Nov 11, 2014

It's my understanding that autosendcmd (-botcmd) only works on channels with less than 1,000 users. The reason seems to be that it runs when receiving the output of /who and that call seems to be skipped when the channel has a large number of users for obvious reasons.

Could this be made configurable?

Alternatively, maybe there'd be an easy way to enable running of command after /join that are not dependent on /who results?

@jillest

This comment has been minimized.

Member

jillest commented Dec 3, 2014

The 1000 is configurable via /set channel_max_who_sync.

There is no easy fix because the general case of -botcmd (with -bots) requires knowing the user@host of all users in the channel. This is quite important on efnet/ircnet-style networks, where you do not want to send a bot password to a user based on nick only.

@madduck

This comment has been minimized.

madduck commented Dec 4, 2014

also sprach Jilles Tjoelker notifications@github.com [2014-12-04 00:31 +0100]:

The 1000 is configurable via /set channel_max_who_sync.

There is no easy fix because the general case of -botcmd (with
-bots) requires knowing the user@host of all users in the
channel. This is quite important on efnet/ircnet-style networks,
where you do not want to send a bot password to a user based on
nick only.

Yes, I am aware of the origin of this command, but it is nowadays
also often used for unconditional auto-commands, IME. Therefore,
maybe irssi just needs a different autorun method, one that does not
depend on network traffic.

The sender e-mail address used (reply.github.com@pobox.madduck.net)
is valid and specific to our correspondence. It should not indicate any
affiliation with your organisation.

Die verwendete E-mail-Adresse (reply.github.com@pobox.madduck.net)
ist gültig und spezifisch für unsere Korrespondenz. Sie soll in keiner Weise
auf eine Verbindung mit Ihrer Organisation hindeuten.

Spamtrap: reply.github.com.bogus@pobox.madduck.net

@jillest

This comment has been minimized.

Member

jillest commented Dec 7, 2014

It could be fixed by distinguishing between -botcmd with and without -bots (rec->botmasks == NULL || !*rec->botmasks, already checked in src/core/channels.c channel_send_autocommands()). A -botcmd without -bots would be sent immediately after the names list is known, while a -botcmd with -bots would wait for the who list as now.

@madduck

This comment has been minimized.

madduck commented Dec 8, 2014

also sprach Jilles Tjoelker notifications@github.com [2014-12-07 21:40 +0100]:

It could be fixed by distinguishing between -botcmd with and
without -bots (rec->botmasks == NULL || !*rec->botmasks,
already checked in src/core/channels.c
channel_send_autocommands()). A -botcmd without -bots would be
sent immediately after the names list is known, while a -botcmd
with -bots would wait for the who list as now.

My thinking exactly…

The sender e-mail address used (reply.github.com@pobox.madduck.net)
is valid and specific to our correspondence. It should not indicate any
affiliation with your organisation.

Die verwendete E-mail-Adresse (reply.github.com@pobox.madduck.net)
ist gültig und spezifisch für unsere Korrespondenz. Sie soll in keiner Weise
auf eine Verbindung mit Ihrer Organisation hindeuten.

Spamtrap: reply.github.com.bogus@pobox.madduck.net

@ailin-nemui ailin-nemui changed the title from autosendcmd only works on small channels to -botcmd only works on small channels Sep 18, 2015

LemonBoy added a commit to LemonBoy/irssi that referenced this issue Jan 14, 2016

Change when the autocmds are sent.
As per irssi#175 if a -botcmd is specified for a given channel without a
-bots parameter then the command is sent right after joining the
channel.
@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 19, 2016

@madduck are you interested in evaluating the fix proposed by LemonBoy

@madduck

This comment has been minimized.

madduck commented Jan 19, 2016

also sprach ailin-nemui notifications@github.com [2016-01-20 04:01 +1300]:

@madduck are you interested in evaluating the fix proposed by LemonBoy

Sorry, I have not seen the fix… until now. I just left a comment and
will gladly try the patch next week when back at my desk.

Best regards,

The sender e-mail address used (reply.github.com@pobox.madduck.net)
is valid and specific to our correspondence. It should not indicate any
affiliation with your organisation.

Die verwendete E-mail-Adresse (reply.github.com@pobox.madduck.net)
ist gültig und spezifisch für unsere Korrespondenz. Sie soll in keiner Weise
auf eine Verbindung mit Ihrer Organisation hindeuten.

Spamtrap: reply.github.com.bogus@pobox.madduck.net

@madduck

This comment has been minimized.

madduck commented Jan 24, 2016

I tried the fix and it works. Thanks!

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 26, 2016

closing via #399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment