New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/names list isn't lined up properly if nicks are in UTF-8 #40

Closed
andrewshadura opened this Issue Jun 16, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@andrewshadura

andrewshadura commented Jun 16, 2014

fe-common/core/fe-channels.c:display_sorted_nicks() isn't wide-character aware; thus, columns in /names list won't be properly aligned if any nicks have wide characters in them.

(Copied from the old bugtracker: FS#575)

@dequis

This comment has been minimized.

Member

dequis commented Jul 2, 2014

Flyspray link: http://bugs.irssi.org/index.php?do=details&task_id=575

There's a patch for 0.8.12 there (still applies cleanly to master)

Also this comment by @jillest

This patch assumes that the nicks are utf-8, which is not necessarily the case

I committed a rebased version of the patch to this branch. Untouched, untested, didn't even change commit message, but if anyone feels like playing with it, it's there.

Personally I have no idea how to make it deal with non-utf-8 encodings.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Sep 18, 2015

care needs to be taken to use the wcwidth functions for screen alignment on terminals

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented May 18, 2016

@andrewshadura please test

@andrewshadura

This comment has been minimized.

andrewshadura commented May 18, 2016

Cool, thanks, will test.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jun 12, 2016

we believe this issue is now fixed, please reopen otherwise

@ailin-nemui ailin-nemui modified the milestones: 0.8.22, 1.0.1 Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment