Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Find a less-global method of deciding when to print netsplits/mode/joins #420
When irssi is looking for more netsplit QUITs, more MODEs, etc, any printed text to any window will cause the accumulated QUITs/MODEs/etc to be printed; I have a window set up as a 'raw' window, printing exactly what irssi receives from connected servers, with no processing. My script to do so currently requires stopping the "print starting" signal while I'm trying to print;
Irssi::signal_add_first("print starting", "ignore_signal"); $window->print($text, MSGLEVEL_NEVER) if ($window); Irssi::signal_remove("print starting", "ignore_signal");
If I don't have this in place, the result is one netsplit line for every user, printed immediately (because my 'raw' script has printed to my raw-input window, causing netsplit detection to conclude the end of the splitting users):
Could this be done in a way that it doesn't rely on watching for printed text? Perhaps if the server sends something that is not another QUIT/MODE/etc?
I agree it shouldn't absolutely hook the
added a commit
Apr 2, 2016
added a commit
Jun 26, 2016
So this goes back to unfixed.
PR #465 tried to fix this
Issue #567 was a regression from that fix
PR #577 fixed that regression
Issue #809 appeared much later and its cause is still not fully understood.
PR #812 reverted most of the original fix (made the filtering a no-op)
So to get this done we have to figure out a fix to #809 that isn't a revert.
referenced this issue
Jan 20, 2018