New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joining +channels is broken #435

Closed
ailin-nemui opened this Issue Mar 10, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@ailin-nemui
Contributor

ailin-nemui commented Mar 10, 2016

the ischannel function removes the "statusmsg" characters and assumes those are @ and + thus breaking @channels and +channels.

the ischannel function must not break /join. maybe we need to separate ischannel for joins and ischannel for privmsgs.

furthermore, statusmsgs should not be assumed to be @+, if it is not present and no WALLCHOPS and no WALLVOICES are in isupport then it should be treated as empty (imo).

CHANTYPES should always be checked prior to stripping statusmsgs
Regression due to #248

cf https://github.com/irssi/irssi/blob/master/src/irc/core/irc-servers.c#L84

@ailin-nemui ailin-nemui added the bug label Mar 10, 2016

@ailin-nemui ailin-nemui added this to the 0.8.18a milestone Mar 10, 2016

@ailin-nemui ailin-nemui added the 0.8.18 label Mar 10, 2016

ailin-nemui added a commit to ailin-nemui/irssi that referenced this issue Mar 11, 2016

LemonBoy added a commit to LemonBoy/irssi that referenced this issue Mar 17, 2016

Do not assume any default value for statusmsg.
If the server didn't send it then just skip the check, the old value it
defaulted to was possibly overlapping with the CHANTYPES leading to an
incorrect behaviour. Fixes irssi#435.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment