New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential terminal state not reset after 2x suspend #450

Closed
ailin-nemui opened this Issue Mar 21, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@ailin-nemui
Contributor

ailin-nemui commented Mar 21, 2016

testing with zsh, after suspending irssi 2x with Ctrl+Z, I don't get working Ctrl+C anymore (for example if I then launch cat). Curiously enough it doesn't seem to happen in bash.

ailin-nemui added a commit to ailin-nemui/irssi that referenced this issue Mar 22, 2016

fix race condition in terminal init
remove the tcgetattr call to a single time on irssi load instead of
querying it each time. Fixes irssi#450
@dequis

This comment has been minimized.

Member

dequis commented Mar 22, 2016

Is this actually a regression from 0.8.17 to 0.8.18?

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Mar 22, 2016

I think this one is not a regression just a regular bug

@dequis

This comment has been minimized.

Member

dequis commented Mar 22, 2016

In that case, can we leave it after 0.8.18a? The two PRs that link to this bug have changes that are small and subtle but look like they could break things in crappy platforms.

...in practice it turns out that we have to make a release to get people to bother to test things, sigh. But this one looks riskier than the others.

ailin-nemui added a commit to ailin-nemui/irssi that referenced this issue Aug 7, 2017

Revert "Merge pull request irssi#452 from LemonBoy/terminfo-cup"
Fixes irssi#733. The fix outlined in irssi#452 had adverse effects for the
following reason. The code removed the restoration path that would go on
the code path from kill SIGTSTP. The problem is this: When Irssi is not
running in a controlling parent (like a shell), the TSTP will in fact be
ignored. In that case, there is no process sending a CONT either and
thus the screen state never gets restored. Luckily, the patch in irssi#457 is
sufficient to prevent the problem in irssi#450 (which lead to the development
of irssi#452). To that end, we do end up with potentially calling
terminfo_cont twice but that is better than not calling it at all.

This reverts commit b1ffd5f, reversing
changes made to 9cb0419.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment