New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window input history works strangely with window history cleared #462

Closed
vague666 opened this Issue Mar 24, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@vague666
Member

vague666 commented Mar 24, 2016

to reproduce:

  • join a new channel or issue /window history -clear
  • enter text but don't press enter
  • press arrow up
  • return to the text you entered... you would assume you'd get to it by arrow down but you are now at
    the start of the history buffer and have to press up to get to the text which is a bit confusing

not sure if this can be improved though, maybe arrow up should be 'stopped' if there's no more items in history?

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Mar 26, 2016

Have a look at how the over_counter field in HISTORY_REC is used in command_history_prev, I do agree the current behaviour is confusing and not very useful

@ailin-nemui ailin-nemui added the bug label Mar 29, 2016

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Mar 29, 2016

additional information it seems to work "right" when the history isn't empty

@josephbisch josephbisch self-assigned this Feb 16, 2017

josephbisch added a commit to josephbisch/irssi that referenced this issue Apr 5, 2017

Fix strange history behavior when history is empty
If text is being entered and then the user presses the up arrow
followed by the down arrow, the expected behavior is to return to the
text being entered. Prior to this commit that was not the case.

Fixes irssi#462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment