New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/help SERVER ADD -port and -! examples incorrect #519

Closed
johannes87 opened this Issue Aug 2, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@johannes87

johannes87 commented Aug 2, 2016

To reproduce:

/network add hackint
/server add -ssl -network hackint -port 9999 irc.hackint.org
/connect hackint

Irssi then connects to irc.hackint.org on port 6667. Tested with irssi 0.8.19 on OS X 10.11.

@johannes87 johannes87 changed the title from /server command seems to ignore -port option to /server add seems to ignore -port option Aug 2, 2016

@johannes87 johannes87 changed the title from /server add seems to ignore -port option to /SERVER ADD seems to ignore -port option Aug 2, 2016

@dequis

This comment has been minimized.

Member

dequis commented Aug 2, 2016

Quoting from #256:

not saying it makes sense, but the reason for this is that -port is for modifying an entry and <address> <port> is for adding an entry. Example:

/server add -network net1 example.com 6697 # add server of network 1
/server add -network net2 example.com 6698 # add server of network 2
/server add -port 6667 example.com # modify port of server in network 2
/server add -port 6668 example.com 6697 # modify port of server in network 1

@johannes87

This comment has been minimized.

johannes87 commented Aug 2, 2016

Thanks. Still, the documentation seems to be wrong. It lists the following command in the examples:

/SERVER ADD -! -auto -host staff.irssi.org -port 6667 -4 -network Freenode -noproxy orwell.freenode.net`

This suggests that "-port" does set the initial port. At least the example should be changed to remove the "-port 6667" IMHO:

/SERVER ADD -! -auto -host staff.irssi.org -4 -network Freenode -noproxy orwell.freenode.net 6667`

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Aug 4, 2016

the help is totally wrong

@ailin-nemui ailin-nemui added the bug label Aug 4, 2016

@ailin-nemui ailin-nemui changed the title from /SERVER ADD seems to ignore -port option to /help SERVER ADD -port and -! examples incorrect Aug 4, 2016

@ailin-nemui ailin-nemui removed the help wanted label Jan 3, 2017

@ailin-nemui ailin-nemui closed this Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment