New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill bell_beeps setting (or make it a no-op) #524

Closed
dequis opened this Issue Aug 7, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@dequis
Member

dequis commented Aug 7, 2016

It doesn't do what people think it does.

People enable it expecting it to enable beeps when they get highlighted. It's not for that.

It's for beeping when anyone in any window sends a ^G character (ascii bell) - and that's without changing the activity level of the window in which it happened.

It's dumb and only trolls ever use it. Also, plenty of guides suggest people to turn it on, ignoring the real effect of doing so.

Any objections to nuke it? Any useful purpose for this setting that I'm missing?

EDIT FROM THE FAR FUTURE:

THIS IS NOT ABOUT SENDING THE BELL CHARACTER TO YOUR TERMINAL WHEN YOU GET HIGHLIGHTED OR GET PRIVATE MESSAGES

NOT HAVING THIS SETTING DOES NOT REMOVE THE ABILITY TO GET BEEPS

YOU DO NOT NEED THIS SETTING

(Sorry for the caps, not mad or anything, but somehow we still get people regularly complaining about this, even people who have seen this ticket.)

@vague666

This comment has been minimized.

Member

vague666 commented Aug 7, 2016

Why not rename it to beep_on_ascii_bel or similar? Maybe somebody finds it useful for some reason?

@dequis

This comment has been minimized.

Member

dequis commented Aug 7, 2016

I really doubt it can be useful ever. A "maybe" isn't enough. I'm looking for concrete use cases, if they even exist.

Also, even that name is ambiguous. For example, in one of the pages that suggests enabling this, someone tried to explain how enabling this setting is a bad idea, by saying "It actually does something far worse. It makes the beep control code send a beep to your terminal", and the author of the post replied:

How is that worse? That’s what I wanted personally – it’s (AFAIK) the only way a console app can make a sound!

To be fair, it wasn't the best explanation of the issue, but it was ambiguous in the same way that beep_on_ascii_bel is.

@ahf

This comment has been minimized.

Member

ahf commented Oct 16, 2016

I'm fine with killing it.

@ahf ahf added this to the 0.8.21 milestone Oct 22, 2016

ahf added a commit to ahf/irssi that referenced this issue Oct 23, 2016

@ahf ahf referenced this issue Oct 23, 2016

Merged

Kill bell_beeps. #565

@ailin-nemui ailin-nemui modified the milestones: 0.8.21, 1.0.1 Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment