New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private messages go to the status window when the other user changes to an equivalent nick #580

Closed
wodim opened this Issue Nov 29, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@wodim

wodim commented Nov 29, 2016

Having a user called Mike^, and knowing ^ and ~ are equivalent, /q mike~, talk to him, and when he responds, you'll see -!- mike~ is now known as Mike^ in the query window but his first message will appear in the status window instead of the query window.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Nov 29, 2016

is this fallout of self-message support or was it broken before (in 0.8.17 or older)

@ailin-nemui ailin-nemui added the bug label Nov 29, 2016

@wodim

This comment has been minimized.

wodim commented Nov 29, 2016

idk

@dequis

This comment has been minimized.

Member

dequis commented Nov 29, 2016

Can reproduce in 0.8.15

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Nov 30, 2016

The fix is pretty simple, we just need to replace various strcmp with server->nick_comp_func when it is appropriate to do so.
The sloppy but quick fix is patching this check since the casemapping-aware function covers the case where only the case differs.
The 'real' fix would be to track down the chain of events that call query_change_nick and make sure to use the casemapping-aware comparison when possible.

In short, fuck you CASEMAPPING

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 2, 2017

can you check if this was fixed by #586

@ailin-nemui ailin-nemui added the WIP label Jan 2, 2017

@wodim

This comment has been minimized.

wodim commented Feb 15, 2017

It's fixed. Anyway I found a related bug: if you /whois mike~, you never see the "End of WHOIS" mark because Irssi does not expect the whois response for Mike^ and waits for mike~'s forever.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Feb 15, 2017

Can you please open another issue for that

@wodim

This comment has been minimized.

wodim commented Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment