New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make irssi_ssl_get_iochannel accessible for plugins #615

Closed
phhusson opened this Issue Jan 11, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@phhusson

phhusson commented Jan 11, 2017

The Quassel protocol doesn't start straight as TLS, but has a protocol-negociation before-hand.
Hence, quassel-irssi can't just use standard use_tls=1 of irssi (unless I've missed something, in which case, please tell!)

At the moment, to handle this, quassel-irssi has a copy/paste of irssi's network-openssl.c, which is obviously ugly, and isn't update-proof (it has been broken by irssi 1.0.0)

Would it be possible to make this symbol public?

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 16, 2017

hi, can you discuss if there are any issues that require you to poll here https://github.com/phhusson/quassel-irssi/blob/master/core/quassel-net.c#L171

ailin-nemui added a commit to ailin-nemui/irssi that referenced this issue Jan 16, 2017

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 16, 2017

please check if this would work

@phhusson

This comment has been minimized.

phhusson commented Jan 17, 2017

Yup, that function is perfect.
For the polling part, it was mostly lazyness, I've now implemented it properly (I think):
phhusson/quassel-irssi@19e8104

quassel_net_ssl_callback is partly a copy/paste of server_connect_callback_init_ssl.
This isn't really a problem I think, though this is a possible improvement.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 17, 2017

cool thanks for the feedback.

@ailin-nemui ailin-nemui added the WIP label Jan 19, 2017

ailin-nemui added a commit to ailin-nemui/irssi that referenced this issue Feb 5, 2017

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Feb 6, 2017

@phhusson from what I can tell you're still having the polling code in line 219 there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment