New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color codes which end in commas both reset background and print comma as literal #740

Closed
GinjaNinja32 opened this Issue Aug 28, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@GinjaNinja32
Contributor

GinjaNinja32 commented Aug 28, 2017

When irssi formats an IRC message containing a color code such as ^C2,, it treats the , as both literal and part of the color code; that is:

^C1,0black on white; ^C2blue on white -> black on white; , blue on white, in the specified colors.
^C1,0black on white; ^C2,blue on default -> black on white; , ,blue on default, again in the specified colors; note the comma before "blue" in the result.

^C2, resets the background, and sets the foreground to blue, then prints a comma.
^C, resets the background but not foreground, and prints the comma similarly.

It appears any color code which ends with a comma both resets the background and adds a literal comma to the string - it should likely only do one of these things; IMO it should reset the background, but I don't mind much either way.

Found on irssi 0.8.20; reproduced successfully on irssi 1.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment