Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ignore overwrites #78
I don't know if I'm missing something here (new user), but after ignoring, say, messages that contain 'lol' only like this: /ignore -regexp -pattern "^[lL][oO][lL]$" * PUBLIC, when trying to /ignore * JOINS PARTS QUITS, the two entries get merged without the regexp pattern and I end up ignoring all public messages. If I add the ignore rules in opposite order or edit config manually it seems to work fine.
You're not missing something, the fact this is inconsistent is a bug.
The problem here is ignore_find() is not flexible enough, so the code in fe-common/core/fe-ignore.c can't specify that it doesn't want ignores with patterns, yet it does ignore them when adding with a pattern:
I actually already made some changes to ignore_find in pull #80, I wonder if it would be worth cleaning up that API a little more so that it's possible to specify not wanting ignores with patterns attached, which /ignore could then use.