New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/hilight generating garbage when passed with multiple -network parameters #787

Closed
AstroSnail opened this Issue Nov 3, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@AstroSnail

AstroSnail commented Nov 3, 2017

EDIT: the bug turns out to be unrelated to the number of -network parameters passed, read comments below.


I haven't tested whether this happens only with /hilight and only with -network.

I wanted to set a hilight on two networks, and instead of passing the networks comma-separated in one -network parameter, I unwittingly passed two -network parameters, and irssi crashed.

Uh oh

I reopened irssi and ran the command again, and this time irssi didn't crash, but the echo of the command contained garbage in the -network parameter.

Found on irssi v1.0.5

Here I run the same command shown on the input bar a number of times.
2017-11-03-123839_swaygrab

@AstroSnail AstroSnail changed the title from /hilight generating garbage when passed with repeated -network parameter to /hilight generating garbage when passed with multiple -network parameters Nov 3, 2017

@josephbisch

This comment has been minimized.

Member

josephbisch commented Nov 3, 2017

Can't reproduce it on v1.0.5. Seems for me, it just uses the last -network parameter specified and I don't get any crashes or displaying of garbage. Maybe there is something about your irssi config that explains why you get this issue, but I'm not able to reproduce it.

@AstroSnail

This comment has been minimized.

AstroSnail commented Nov 3, 2017

OK, it indeed appears to be something in my config, I tried a fresh config and it didn't happen, and copying the old config to it again crashed with

*** Error in `irssi': double free or corruption (fasttop): 0x0000558c553e8a30 ***
Aborted (core dumped)

I'll try to make a minimum config that exibits this bug

@josephbisch

This comment has been minimized.

Member

josephbisch commented Nov 3, 2017

Since it says Aborted (core dump), you should have a file named core or core.1234 where 1234 is the pid of the irssi instance that crashed. You can see the crash.txt document for how to get a backtrace, which may be helpful to allow us to see where the crash is actually occurring. Though if it isn't a build with debug symbols that might not be too informative.

Here are the relevant steps from crash.txt, once you find the core file.

 gdb irssi core
 set logging file bt.log
 set logging on
 bt
 set logging off
 quit

Provide the bt.log file.
@AstroSnail

This comment has been minimized.

AstroSnail commented Nov 3, 2017

I have a fairly minimal crash case now, the config only contains

hilights = (
  {
    text = "@AstroSnail";
    nick = "yes";
    fullword = "yes";
    servertag = "AstroZNC-BitlBee,BitlBee";
  }
);

and I run
/hilight -network BiltBee @AstroSnail

@josephbisch

This comment has been minimized.

Member

josephbisch commented Nov 3, 2017

Thanks reproduced it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment