New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO_ACT ignores not working #900

Closed
vague666 opened this Issue Aug 2, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@vague666
Copy link
Member

vague666 commented Aug 2, 2018

I'm testing with v1.2-ga0630944(patched with #892) and can't see PUBLICS in act bar with ignore set to
1 *: NO_ACT JOINS PARTS QUITS MODES NICKS or
1 #irssi: NO_ACT JOINS PARTS QUITS MODES NICKS
and activity_hide_level is cleared
No scripts loaded and /window hidelevel is NONE
If I remove the ignore then everything works as expected

ailin-nemui added a commit that referenced this issue Aug 6, 2018

@ailin-nemui

This comment has been minimized.

Copy link
Contributor

ailin-nemui commented Sep 3, 2018

@dequis dequis reopened this Sep 17, 2018

@dequis

This comment has been minimized.

Copy link
Member

dequis commented Sep 17, 2018

I just ran into this issue in a commit roughly equivalent to current master

(precisely: dequis@2256597, branched from 1bbd9f3 and merged a bunch of PRs locally before those got merged to master, but definitely includes 85df01d which supposedly fixes this)

Can anyone confirm?

@vague666

This comment has been minimized.

Copy link
Member

vague666 commented Sep 17, 2018

The NO_ACT flag appears to flag all messages as hidden while the first ignore does ignore test
1 vague*!vague@irssi/staff/vague: ALL -regexp -network freenode -pattern TEST
2 vague
!*vague@irssi/staff/vague: NO_ACT ALL -network freenode
If I remove the HIDDEN flag from /window hidelevel then the messages appear, but it does hide them from activity too
I tested this with HEAD

@vague666

This comment has been minimized.

Copy link
Member

vague666 commented Sep 17, 2018

I reckon it comes from here: https://github.com/irssi/irssi/blob/master/src/core/ignore.c#L87
but damn if I know the logic behind it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment