Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test on Big Endian 64bit, due to pointer size mismatch #1014

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@ailin-nemui
Copy link
Contributor

commented Feb 13, 2019

No description provided.

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

the code was wrong (casting a small size ptr to a larger one)

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

reported via debian build infrastructure / @rhonda

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

@dwfreed

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

The fix makes sense, but why are you making a block here? I'd just put the variable declaration at the top of the function with the others.

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

it's just a test.. but you wouldn't want any access to the temporary buf_len, could lead to wrong usage

@ailin-nemui ailin-nemui merged commit 01ce66c into irssi:master Feb 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:fix-be64 branch Feb 19, 2019

@ailin-nemui ailin-nemui added this to the 1.2.1 milestone Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.