Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore 8bit support in input entry #1057

Merged
merged 1 commit into from Jun 28, 2019

Conversation

Projects
None yet
2 participants
@ailin-nemui
Copy link
Contributor

commented Jun 17, 2019

This should fix #1018

Regression of #764

Based on patch by @saahriktu

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

at least until #671 is finished

@dequis

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Kinda weird to check unichar_isprint against a character that might not be unicode after all, but i suspect this isn't the only place where that is done. Would be nice to know how to test this.

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

I agree and I haven't tested this, only followed similar code

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

@irssi irssi deleted a comment from suiited Jun 27, 2019

@ailin-nemui ailin-nemui merged commit 8551dd9 into irssi:master Jun 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui added this to the 1.2.1 milestone Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.