New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no split utf8 from the bug tracker #12

Merged
merged 1 commit into from Jun 18, 2014

Conversation

Projects
None yet
8 participants
@ailin-nemui
Contributor

ailin-nemui commented Jun 11, 2014

FS#870 -
[PATCH] UTF-8 characters corrupted once for every 32k text

@andrewshadura

This comment has been minimized.

andrewshadura commented Jun 16, 2014

Yes, this is a really annoying bug.

@@ -154,6 +155,17 @@ static void text_chunk_append(TEXT_BUFFER_REC *buffer,
chunk = buffer->cur_text;
while (chunk->pos + len >= TEXT_CHUNK_USABLE_SIZE) {
left = TEXT_CHUNK_USABLE_SIZE - chunk->pos;
/* don't split utf-8 character. (assume we can split non-utf8 anywhere. */

This comment has been minimized.

@coekie

coekie Jun 16, 2014

Contributor

nit: missing parenthese

@coekie

This comment has been minimized.

Contributor

coekie commented Jun 16, 2014

lgtm!

@dequis

This comment has been minimized.

Member

dequis commented Jun 17, 2014

Oh wow, so this was it. I always thought my TCP was broken... The 32kb are from TEXT_CHUNK_USABLE_SIZE, I guess? The commit subject line could use some improvement. I suggest "Fix UTF-8 character corruption every 32kb of text buffer"

@ahf

This comment has been minimized.

Member

ahf commented Jun 18, 2014

LGTM as well - please resubmit with @coekie's nit fixed.

ahf added a commit that referenced this pull request Jun 18, 2014

Merge pull request #12 from ailin-nemui/no-split-utf8
no split utf8 from the bug tracker

@ahf ahf merged commit 8c08eef into irssi:master Jun 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:no-split-utf8 branch Jun 18, 2014

@fgeek

This comment has been minimized.

fgeek commented Jun 30, 2014

@ahf Could you please mark http://bugs.irssi.org/index.php?do=details&task_id=870 as closed / handled in bugs.irssi.org too so we have some kind of idea how many issues are still open in bugs.irssi.org and so on.

@GeertHauwaerts

This comment has been minimized.

Member

GeertHauwaerts commented Jun 30, 2014

@fgeek I've closed the issue on the bugs.irssi.org tracker.

@fgeek

This comment has been minimized.

fgeek commented Jun 30, 2014

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment