New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-after-free bug with cached settings values #147

Merged
merged 1 commit into from Oct 6, 2014

Conversation

Projects
None yet
3 participants
@ahf
Member

ahf commented Sep 29, 2014

This patch fixes a couple of use-after-free bugs when caching various
string related setting values.

Fixes: #143

g_free_not_null(log_theme_name);
log_theme_name = g_strdup(settings_get_str("log_theme"));
if (*log_theme_name == '\0')
log_theme_name = NULL;

This comment has been minimized.

@ailin-nemui

ailin-nemui Sep 30, 2014

Contributor

I see an issue...

Fix use-after-free bug with cached settings values
This patch fixes a couple of use-after-free bugs when caching various
string related setting values.

Fixes: #143
@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Oct 4, 2014

lgtm

@ahf

This comment has been minimized.

Member

ahf commented Oct 6, 2014

I'm being a naughty boy and will approve my own patch.

ahf added a commit that referenced this pull request Oct 6, 2014

Merge pull request #147 from ahf/bugfix-143
Fix use-after-free bug with cached settings values

@ahf ahf merged commit ec0360b into irssi:master Oct 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@GeertHauwaerts

This comment has been minimized.

Member

GeertHauwaerts commented Oct 14, 2014

Git Inception :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment