New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up nicklist and window_find operations #24

Merged
merged 2 commits into from Jun 15, 2014

Conversation

Projects
None yet
2 participants
@ailin-nemui
Contributor

ailin-nemui commented Jun 11, 2014

Currently there is a N^4 attempt to locate a correct target window in
a bogus try to support IRCNet !channels, remove that.

Also, despite the Nicklist being implemented as a hash table, any nick
list operation does a forEach on the whole nick list. This might slow
down on huge channels, so use the hash instead.

@@ -303,6 +303,7 @@ static void get_nicks_same_hash(gpointer key, NICK_REC *nick,
GSList *nicklist_get_same(SERVER_REC *server, const char *nick)
{
NICKLIST_GET_SAME_REC rec;
NICK_REC *list;

This comment has been minimized.

@ahf

ahf Jun 11, 2014

Member

This is unused.

This comment has been minimized.

@ailin-nemui

ailin-nemui Jun 11, 2014

Contributor

oops

ahf added a commit that referenced this pull request Jun 15, 2014

Merge pull request #24 from ailin-nemui/speedup
Speed up nicklist and window_find operations

@ahf ahf merged commit 0331970 into irssi:master Jun 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:speedup branch Jun 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment