New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for prepending to the cutbuffer in addition to replacing it. #353

Merged
merged 9 commits into from Jan 26, 2016

Conversation

Projects
None yet
3 participants
@toddpratt
Contributor

toddpratt commented Nov 13, 2015

No description provided.

@@ -1,6 +1,8 @@
#ifndef __GUI_ENTRY_H
#define __GUI_ENTRY_H
#define CUTBUFFER_PREPEND 42

This comment has been minimized.

@dequis

dequis Nov 13, 2015

Member

I guess this line is redundant now

@dequis

This comment has been minimized.

Member

dequis commented Nov 13, 2015

Welcome back! Just skimmed but I like what i see so far.

size * sizeof(unichar));
memcpy(entry->cutbuffer + size, tmpcutbuffer,
entry->cutbuffer_len * sizeof(unichar));

This comment has been minimized.

@dequis

dequis Nov 13, 2015

Member

Indentation got really weird in this line.

@@ -624,7 +646,6 @@ void gui_entry_erase_word(GUI_ENTRY_REC *entry, int to_space)
}
if (to > 0) to++;
gui_entry_erase(entry, entry->pos-to, TRUE);

This comment has been minimized.

@dequis

dequis Nov 13, 2015

Member

What's up with this line being deleted? Mistake or somehow intentional?

This comment has been minimized.

@toddpratt

toddpratt Nov 14, 2015

Contributor

It was not intentional. Fixed.

@dequis dequis added the WIP label Nov 18, 2015

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 11, 2016

it should be extended with appending to the cutbuffer as well

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 26, 2016

@toddpratt I'll merge this now, I expect your follow ups

ailin-nemui added a commit that referenced this pull request Jan 26, 2016

Merge pull request #353 from toddpratt/master
Allow for prepending to the cutbuffer in addition to replacing it.

@ailin-nemui ailin-nemui merged commit dc03baa into irssi:master Jan 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment