Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getaddrinfo v6 flag #410

Merged
merged 4 commits into from Feb 3, 2016

Conversation

Projects
None yet
2 participants
@LemonBoy
Copy link
Member

commented Jan 27, 2016

Stacked on top of #408.

LemonBoy added some commits Jan 27, 2016

Delete the HAVE_IPV6 ifdef.
Welcome to the future.
Update the configure script and INSTALL.
Now that HAVE_IPV6 is gone remove all the references from the
buildscript and documentation.
Add AI_ADDRCONFIG to the getaddrinfo hints.
A first step to untangle the ipv4 vs ipv6 mess.
At the time of writing Linux, OpenBSD and FreeBSD all support the
AI_ADDRCONFIG flag.
@ailin-nemui

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2016

I am not sure how this would affect reconnects after interface configuration changes (IPv6 added etc)

@LemonBoy

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2016

The currently behaviour is the worst case scenario with this. 10/10 would merge.

@ailin-nemui

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2016

currently you can use -4 or -6 to choose which server you want to connect to, but if you do not even retrieve those IPs then that won't be possible anymore

@LemonBoy

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2016

If there are no AAAA records that means there's no interface capable of connecting to an ipv6 address, so the -6 is going to fail anyway.
With this patch we just avoid returning an unsupported address.

ailin-nemui added a commit that referenced this pull request Feb 3, 2016

@ailin-nemui ailin-nemui merged commit af229a8 into irssi:master Feb 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ailin-nemui

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2016

let's try this then

@LemonBoy LemonBoy deleted the LemonBoy:getaddrinfo-v6-flag branch Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.