New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an append operation to cut buffer handling #414

Merged
merged 5 commits into from Feb 17, 2016

Conversation

Projects
None yet
3 participants
@toddpratt
Contributor

toddpratt commented Jan 30, 2016

also, checks that g_new succeeded and NOOPs if it failed.

@dequis

This comment has been minimized.

Member

dequis commented Jan 30, 2016

I don't think we care about handling memory allocation failures...

Also, use tabs for indentation instead of spaces.

@toddpratt

This comment has been minimized.

Contributor

toddpratt commented Jan 30, 2016

OK. On a previous PR, someone suggested I check the success of g_new(), but either way is fine with me.

@@ -582,25 +582,36 @@ void gui_entry_erase(GUI_ENTRY_REC *entry, int size, CUTBUFFER_UPDATE_OP update_
if (size == 0 || entry->pos < size)
return;
if (entry->cutbuffer_len == 0) {
update_cutbuffer = CUTBUFFER_UPDATE_REPLACE;

This comment has been minimized.

@ailin-nemui

ailin-nemui Feb 8, 2016

Contributor

-> fix indentation

ailin-nemui added a commit that referenced this pull request Feb 17, 2016

Merge pull request #414 from toddpratt/master
add an append operation to cut buffer handling

@ailin-nemui ailin-nemui merged commit 4650665 into irssi:master Feb 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment