Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irssi proxy: allow multiplexing multiple networks over a single port #425

Merged
merged 5 commits into from Feb 24, 2016

Conversation

Projects
None yet
3 participants
@mauke
Copy link
Contributor

commented Feb 18, 2016

No description provided.

@dequis

This comment has been minimized.

Copy link
Member

commented Feb 18, 2016

Would have been better to avoid unrelated formatting changes, it makes the diff harder to review.

The implementation looks good. Haven't tested it yet.

Not a huge fan of the ? on the UI side but I see how it makes sense to keep the code simpler.

@ailin-nemui

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2016

tip for @dequis use https://github.com/irssi/irssi/pull/425/files?w=1 for review . sadly does not allow line comments in that view

@mauke

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2016

I've been running this for a few days now. No problems so far.

ailin-nemui added a commit that referenced this pull request Feb 24, 2016

Merge pull request #425 from mauke/irssiproxy-multiplex
irssi proxy: allow multiplexing multiple networks over a single port

@ailin-nemui ailin-nemui merged commit f83a29b into irssi:master Feb 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauke mauke deleted the mauke:irssiproxy-multiplex branch Feb 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.