New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SASL EXTERNAL #432

Merged
merged 1 commit into from Mar 8, 2016

Conversation

Projects
None yet
3 participants
@grawity
Contributor

grawity commented Mar 8, 2016

First commit makes the authentication actually work rather than hanging on "You have not registered".

Second commit adds authzid support, similar to how it is implemented in PLAIN.

As tradition goes, the latter is untested as of now.

Fix SASL EXTERNAL authentication
The "AUTHENTICATE" command is always required – it's part of the IRCv3
SASL framing. RFC 4422 only documents the Base64 payload.
@grawity

This comment has been minimized.

Contributor

grawity commented Mar 8, 2016

Upon further consideration, sending the current username as authzid doesn't make enough sense to be worth the extra code, so that part was dropped.

(Although in that case, PLAIN should be updated to send an empty authzid as well.)

LemonBoy added a commit that referenced this pull request Mar 8, 2016

@LemonBoy LemonBoy merged commit 66e9c4b into irssi:master Mar 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui added this to the 0.8.18a milestone Mar 11, 2016

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Mar 22, 2016

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Mar 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment