Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sasl timeout source when the server disconnects #438

Merged
merged 1 commit into from Mar 17, 2016

Conversation

Projects
None yet
3 participants
@dequis
Copy link
Member

commented Mar 11, 2016

No description provided.

@ailin-nemui ailin-nemui added this to the 0.8.18a milestone Mar 11, 2016

@LemonBoy

This comment has been minimized.

Copy link
Member

commented Mar 12, 2016

LGTM

{
g_return_if_fail(server != NULL);

if (!IS_IRC_SERVER(server)) {

This comment has been minimized.

Copy link
@ailin-nemui

ailin-nemui Mar 14, 2016

Contributor

any particular reason you're not using g_return_if_fail here too? not that'd matters

This comment has been minimized.

Copy link
@dequis

dequis Mar 14, 2016

Author Member

...dunno. I copied this part from equivalent signal handlers.

ailin-nemui added a commit that referenced this pull request Mar 17, 2016

Merge pull request #438 from dequis/sasl-timeout-disconnect
Remove sasl timeout source when the server disconnects

@ailin-nemui ailin-nemui merged commit 49bdd17 into irssi:master Mar 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Mar 22, 2016

Merge pull request irssi#438 from dequis/sasl-timeout-disconnect
Remove sasl timeout source when the server disconnects

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Mar 22, 2016

Merge pull request irssi#438 from dequis/sasl-timeout-disconnect
Remove sasl timeout source when the server disconnects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.