New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error when a chatnet has no available url #443

Merged
merged 3 commits into from Mar 22, 2016

Conversation

Projects
None yet
3 participants
@LemonBoy
Member

LemonBoy commented Mar 18, 2016

I spent too much time thinking IRCNet servers were shit but it turns out I had no server block for it and irssi kept trying to connect to my ISP page-not-found redirect.

Hilarious 馃殌

@@ -73,6 +73,12 @@ static SERVER_CONNECT_REC *get_server_connect(const char *data, int *plus_addr,
conn = server_create_conn(proto != NULL ? proto->id : -1, addr,
atoi(portstr), chatnet, password, nick);
if (conn == NULL) {
g_warning("Cuntnugget");

This comment has been minimized.

@dequis

dequis Mar 18, 2016

Member

uhm...

This comment has been minimized.

@LemonBoy

LemonBoy Mar 18, 2016

Member

Well, if I get a ACK on the behaviour I'll add a new CMDERR_ later

Throw an error when a chatnet has no available url
If you type /connect <CN> and the chatnet <CN> has no url available
let's just throw an error instead of trying to process <CN> as a url.
@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Mar 19, 2016

We need to raise abi version due to formats addition

Bump the ABI version
Since a new format has been added.
@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Mar 20, 2016

lgtm

@@ -323,6 +323,8 @@ server_create_conn(int chat_type, const char *dest, int port,
rec = create_chatnet_conn(chatrec->name, port, password, nick);

This comment has been minimized.

@ailin-nemui

ailin-nemui Mar 21, 2016

Contributor

just return rec; ?

@ailin-nemui ailin-nemui removed the auto-merge label Mar 22, 2016

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Mar 22, 2016

PR updated and ready to 馃殌

ailin-nemui added a commit that referenced this pull request Mar 22, 2016

Merge pull request #443 from LemonBoy/chatnet
Throw an error when a chatnet has no available url

@ailin-nemui ailin-nemui merged commit 9cb0419 into irssi:master Mar 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@LemonBoy LemonBoy deleted the LemonBoy:chatnet branch Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment