New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call terminfo_cont() twice on resume #452

Merged
merged 1 commit into from Mar 22, 2016

Conversation

Projects
None yet
2 participants
@LemonBoy
Member

LemonBoy commented Mar 21, 2016

It was only called to push the current state onto the stack since the
terminal would be reset in the SIGCONT handler.
Fixes some weirdness when using ^Z with zsh.

Fixes #450, at least for me.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Mar 21, 2016

thanks for looking into it. I'm not convinced this is enough, I'll comment more later

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Mar 22, 2016

are there systems which do not properly send sigcont, thus warranting or being the reason for the original code?

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Mar 22, 2016

Not that I am aware of

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Mar 22, 2016

title/message still needs update

Don't call terminfo_cont() twice on resume
Fixes some weirdness when using ^Z with zsh.

@LemonBoy LemonBoy changed the title from Use a single smcup instead of calling terminfo_cont() to Don't call terminfo_cont() twice on resume Mar 22, 2016

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Mar 22, 2016

Updated

ailin-nemui added a commit that referenced this pull request Mar 22, 2016

Merge pull request #452 from LemonBoy/terminfo-cup
Don't call terminfo_cont() twice on resume

@ailin-nemui ailin-nemui merged commit b1ffd5f into irssi:master Mar 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@LemonBoy LemonBoy deleted the LemonBoy:terminfo-cup branch Jul 14, 2016

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Aug 7, 2017

Revert "Merge pull request irssi#452 from LemonBoy/terminfo-cup"
Fixes irssi#733. The fix outlined in irssi#452 had adverse effects for the
following reason. The code removed the restoration path that would go on
the code path from kill SIGTSTP. The problem is this: When Irssi is not
running in a controlling parent (like a shell), the TSTP will in fact be
ignored. In that case, there is no process sending a CONT either and
thus the screen state never gets restored. Luckily, the patch in irssi#457 is
sufficient to prevent the problem in irssi#450 (which lead to the development
of irssi#452). To that end, we do end up with potentially calling
terminfo_cont twice but that is better than not calling it at all.

This reverts commit b1ffd5f, reversing
changes made to 9cb0419.

ailin-nemui added a commit that referenced this pull request Aug 10, 2017

Merge pull request #737 from ailin-nemui/fix-733
Revert "Merge pull request #452 from LemonBoy/terminfo-cup"

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Dec 7, 2017

Merge pull request irssi#737 from ailin-nemui/fix-733
Revert "Merge pull request irssi#452 from LemonBoy/terminfo-cup"

lkundrak pushed a commit to lkundrak/irssi that referenced this pull request Feb 16, 2018

Merge pull request irssi#737 from ailin-nemui/fix-733
Revert "Merge pull request irssi#452 from LemonBoy/terminfo-cup"

(cherry picked from commit 1347101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment