New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small adjustments to the netsplit code. #465

Merged
merged 3 commits into from Oct 11, 2016

Conversation

Projects
None yet
2 participants
@LemonBoy
Member

LemonBoy commented Apr 2, 2016

Wrt issue #420

This is a RFC, I repeat, this is a RFC ⚠️

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Apr 7, 2016

I haven't reviewed it but it does seem like a good improvement over the previous approach

if (server->netjoins != NULL)
print_netjoins(server);
}
if (dest->level != MSGLEVEL_MSGS)

This comment has been minimized.

@ailin-nemui

ailin-nemui May 9, 2016

Contributor

MSGS should be private messages, so we are never printing the netjoins?

LemonBoy added some commits Apr 2, 2016

Some small adjustments to the netsplit code.
By making the signal handler hooked to the "print starting" event
smarter we can avoid dumping the whole netsplit stats for every
server/channel when a message arrives.

Issue #420

@ailin-nemui ailin-nemui merged commit 61590f3 into irssi:master Oct 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Jan 10, 2018

revert netsplit print optimisation
this reverts part of irssi#465

unfortunately we need to further refine the initial patch

 - when filtering by channel, the whole split is cleaned up neverheless
 - something similar happens for the netjoins
 - furthermore, we cannot wait only for PUBLIC msgs, j/p/q are equivally relevant for temporal integrity

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Jan 10, 2018

revert netsplit print optimisation
this reverts part of irssi#465

unfortunately we need to further refine the initial patch

 - when filtering by channel, the whole split is cleaned up nevertheless
 - something similar happens for the netjoins
 - furthermore, we cannot wait only for PUBLIC msgs, j/p/q are equivalently relevant for temporal integrity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment