New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to make /hilight case sensitive #476

Merged
merged 5 commits into from Apr 30, 2016

Conversation

Projects
None yet
3 participants
@isundil
Contributor

isundil commented Apr 28, 2016

See #421

B Thibault added some commits Apr 28, 2016

B Thibault
Ref #421 (Add an option to make /hilight case sensitive)
Allow use of /hilight -case exAMPle (compatible with other options)
Added matchcase to hilight config file (exemple: { text = exAMPle; matchcase = yes; } )
@isundil

This comment has been minimized.

Contributor

isundil commented Apr 28, 2016

I'm not sure I understand Travis, the outputed error seems to be non-blocking on the others pull-requests

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Apr 29, 2016

Looks fine code-wise with one minor remark about the choice of names, right now you use -case and matchcase in the command line and the config respectively and it'd be nice to have both named the same way.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Apr 29, 2016

Thanks for your contribution, if I'm not mistaken the code is lacking the regex case

@isundil

This comment has been minimized.

Contributor

isundil commented Apr 29, 2016

Yes, I thought they were a regexp flag in preg, but obviously it doesn't

match = rec->fullword ?
strstr_full(text, rec->text) :
strstr(text, rec->text);
}

This comment has been minimized.

@ailin-nemui

ailin-nemui Apr 30, 2016

Contributor

please keep } else { style

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Apr 30, 2016

thanks. please increase ABI version in src/common.h (change in struct/header file)

@ailin-nemui ailin-nemui merged commit cf98260 into irssi:master Apr 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment