Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve perl @INC detection #479

Merged
merged 2 commits into from May 17, 2016

Conversation

Projects
None yet
3 participants
@ailin-nemui
Copy link
Contributor

commented May 9, 2016

might fix #132

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2016

personally I would go so far as to suggest packagers that they ./configure --with-perl-lib=/usr/lib64/irssi/perl5/$(perl -e 'print substr $^V, 1') instead of the current --with-perl-lib=site default. Maybe we can change our default in the future

@dequis

This comment has been minimized.

Copy link
Member

commented May 9, 2016

I don't know enough about perl or autotools to "review" this, so just commenting to say hi.

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2016

hi @dequis !

@gedge

This comment has been minimized.

Copy link

commented May 10, 2016

this does work on my system, with a minor tweak (that may need to be put into the FreeBSD port patches) on line 483 (to add the make flag --no-print-directory)

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2016

hi, does it work with -s instead of --no-print-directory (I added such a commit above)? latter is not portable

@ailin-nemui ailin-nemui merged commit 5564f85 into irssi:master May 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:improve-perl-lib branch May 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.