Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default STATUSMSG to @ instead of @+ if it's missing #533

Merged
merged 1 commit into from Sep 4, 2016

Conversation

Projects
None yet
2 participants
@dequis
Copy link
Member

commented Aug 24, 2016

This fixes two issues:

  • IRCNet doesn't have STATUSMSG, but it supports +channels, and including + in the default value meant processing those incorrectly
  • The "bahamut hack", for old servers that support but don't advertise STATUSMSG, didn't work since ischannel_func doesn't use the default.

The choice of @ intentionally leaves out support for other STATUSMSG (for example, AzzurraNet's bahamut 1.4 fork seemed to support + and % in any order, contradicting the comment in the code).

I think this is a decent tradeoff, given how those servers are uncommon and relying on +# or %# is even less common than @#.

Fixes #531

Set the default STATUSMSG to @ instead of @+ if it's missing
This fixes two issues:

- IRCNet doesn't have STATUSMSG, but it supports +channels, and
  including + in the default value meant processing those incorrectly

- The "bahamut hack", for old servers that support but don't advertise
  STATUSMSG, didn't work since ischannel_func doesn't use the default.

The choice of @ intentionally leaves out support for other STATUSMSG
(for example, AzzurraNet's bahamut 1.4 fork seemed to support + and % in
any order, contradicting the comment in the code).

I think this is a decent tradeoff, given how those servers are uncommon
and relying on +# or %# is even less common than @#.

Fixes #531

@dequis dequis force-pushed the dequis:statusmess branch from e00ef58 to 3429c1a Aug 24, 2016

@LemonBoy LemonBoy referenced this pull request Sep 2, 2016

Closed

+channel #531

@LemonBoy LemonBoy merged commit e4f8abc into irssi:master Sep 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Sep 21, 2016

Merge pull request irssi#533 from dequis/statusmess
Set the default STATUSMSG to @ instead of @+ if it's missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.