New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the CAP fields to the perl scripts. #542

Merged
merged 2 commits into from Sep 22, 2016

Conversation

Projects
None yet
4 participants
@LemonBoy
Member

LemonBoy commented Sep 13, 2016

No description provided.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Sep 13, 2016

@dequis

This comment has been minimized.

Member

dequis commented Sep 14, 2016

@ailin-nemui I would have pinged you, I'm not very familiar with these perl incantations.

But I guess you're just asking if it's okay to expose cap_complete, cap_supported and cap_active. Seems like a step in the right direction, sure.

Are those supposed to read-only?

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Sep 14, 2016

Yes, you're supposed to use cap_toggle to add/remove some capabilities. But that's not exposed to the Perl side yet.

@grawity

This comment has been minimized.

Contributor

grawity commented Sep 14, 2016

Aside: When should scripts actually use cap_toggle? Will there be a signal after irssi receives CAP LS, and updates cap_supported, or after it receives CAP ACK and updates cap_active?

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Sep 14, 2016

If you call cap_queue before the connection then the caps are just queued and batch-requested when a CAP LS arrivare, otherwise they're requested on the spot.
Same goes for removals, it should be pretty much DWIM.

@dequis

This comment has been minimized.

Member

dequis commented Sep 15, 2016

Looks like you're missing an #include for the last commit

@ailin-nemui ailin-nemui merged commit 31044ec into irssi:master Sep 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment