New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process the nick changes in queries before the PRIVMSG is handled. #586

Merged
merged 1 commit into from Jan 2, 2017

Conversation

Projects
None yet
2 participants
@LemonBoy
Member

LemonBoy commented Dec 15, 2016

The event privmsg handler in irc-queries.c kicks in too late and renames the query so the privmsg ends up in the wrong window.
Tested with a local ratbox instance, had a lengthy conversation between me and myself over two irssi instances.
PS: We might need something for the CTCP too.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Dec 15, 2016

any idea about the query_change_address code path which may now not be executed?

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Dec 15, 2016

I think we can just add that check too, g_strcmp0(query->address, address) should suffice if I'm not mistaken. I didn't add it right away because I couldn't find a quick way to test that path and ran out of time ¯\_(ツ)_

Process the nick changes in queries before the PRIVMSG is handled.
Otherwise we end up with the message in the status window since the
frontend knows jack shit about the casemapping option when it tries to
find the associated window for the query.

@LemonBoy LemonBoy changed the title from kProcess the nick changes in queries before the PRIVMSG is handled. to Process the nick changes in queries before the PRIVMSG is handled. Dec 15, 2016

@ailin-nemui ailin-nemui merged commit 91f48c6 into irssi:master Jan 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment