Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assertion to statusbar_read_group #587

Merged
merged 1 commit into from Dec 21, 2016

Conversation

Projects
None yet
2 participants
@ailin-nemui
Copy link
Contributor

commented Dec 15, 2016

fix #564

@dequis

This comment has been minimized.

Copy link
Member

commented Dec 15, 2016

Is this the sort of g_critical assertion that is supposed to stop the config from loading?

It fixes the issue but the error message goes to stderr and is only visible after /quit switches back from the alternate screen.

(edit: not a blocker, as i think the other fixes had the same issue, just curious)

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2016

thanks for testing. I believe there was a reason for restoring the loglev (in irssi.c) before finishing the textui. but I can't remember :-(

@ailin-nemui ailin-nemui merged commit 07050e2 into irssi:master Dec 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:sbar_crash branch Jan 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.