New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax on /help SERVER example #606

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Jan 6, 2017

Fix syntax on /help SERVER resolve issue #519

Lasse Toimela

@ailin-nemui ailin-nemui merged commit 808a11a into irssi:master Jan 6, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 6, 2017

thanks

@dequis

This comment has been minimized.

Member

dequis commented Jan 6, 2017

Actually that's valid syntax to modify the port of an existing server

@dequis

This comment has been minimized.

Member

dequis commented Jan 6, 2017

Eh nevermind this was mentioned in the other ticket. But I don't think this change clarifies that

@ghost

This comment has been minimized.

ghost commented Jan 6, 2017

@dequis, you're right. Maybe we should add "-port 6667" to /SERVER MODIFY example?

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 6, 2017

we need to double check if irssi has a bug in not actually allowing to add multiple same named servers with different ports

iirc the syntax is supposed to be /server -modify newport servername oldport, but /server add only supports /server add servername port

maybe server add should also be fixed to accept -port?

@ghost

This comment has been minimized.

ghost commented Jan 6, 2017

I tried to add server with same name but different port. Irssi just says "18:15 -!- Irssi: Server orwell.freenode.net saved" but still doesn't do anything. It doesn't modify old entry or add new one.

I think it would be most logical solution to fix server add and then revert this pr.

@ghost

This comment has been minimized.

ghost commented Jan 6, 2017

@ailin-nemui I did some more tinkering around and now have branch where server add accept -port (https://github.com/or4n/irssi/tree/server-add-cmd). Do you think I should make PR from that?

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Feb 5, 2017

Merge pull request irssi#606 from or4n/master
Fix syntax on /help SERVER example

@ailin-nemui ailin-nemui added this to the 1.0.1 milestone Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment