New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow g_strsplit with call to g_strfreev #608

Merged
merged 1 commit into from Jan 8, 2017

Conversation

Projects
None yet
4 participants
@tijko
Contributor

tijko commented Jan 7, 2017

No description provided.

@@ -748,6 +748,7 @@ static char *get_nicks(IRC_SERVER_REC *server, WI_ITEM_REC *item,
signal_emit("error command", 1,
GINT_TO_POINTER(CMDERR_NOT_GOOD_IDEA));
signal_stop();
g_strfreev(matches);

This comment has been minimized.

@LemonBoy

LemonBoy Jan 7, 2017

Member

This would be better placed after the g_string_free so that it matches the final sequence and the allocation order, other than this small nit the patch looks good to me.

@tijko

This comment has been minimized.

Contributor

tijko commented Jan 7, 2017

I made the edit and squashed the commits into one

@@ -743,6 +743,7 @@ static char *get_nicks(IRC_SERVER_REC *server, WI_ITEM_REC *item,
g_hash_table_lookup(optlist, "yes") == NULL) {
/* too many matches */
g_string_free(str, TRUE);
g_strfreev(matches);

This comment has been minimized.

@dequis

dequis Jan 7, 2017

Member

While the indentation is a mess (yep, there's another wrong line in the context part of this diff), we try to avoid making the problem worse. Tabs instead of spaces please.

This comment has been minimized.

@tijko

tijko Jan 7, 2017

Contributor

My fault, edited to tabs. I usually make small commits on a project if I'm not sure of how they will be received. You and @LemonBoy have been cool about this small off-by-1 change, thanks! I have really enjoyed the project too :)

This comment has been minimized.

@dequis

@LemonBoy LemonBoy merged commit 38ea52d into irssi:master Jan 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Feb 5, 2017

Merge pull request irssi#608 from tijko/master
Follow g_strsplit with call to g_strfreev

@ailin-nemui ailin-nemui added this to the 1.0.1 milestone Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment