New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression in completion #613

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Projects
None yet
2 participants
@ailin-nemui
Contributor

ailin-nemui commented Jan 9, 2017

fixes #609

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Jan 9, 2017

Looks right but in what case exactly the separator is a character different than a space?

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Jan 9, 2017

good question... I know that we should be able to complete eg /join #abc,#def,#ghi with , as the separator but I wonder if it matters in this branch (or if it gets it right even)

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Jan 9, 2017

Good to know, I've tried that out and it seems to complete the /j with a comma-separated list of channels just fine with this patch.

@LemonBoy LemonBoy merged commit 305b02f into irssi:master Jan 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:fix_completion branch Jan 22, 2017

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Feb 5, 2017

@ailin-nemui ailin-nemui added this to the 1.0.1 milestone Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment