Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide net_start_ssl api #622

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
2 participants
@ailin-nemui
Copy link
Contributor

commented Jan 16, 2017

fixes #615

return NULL;
ssl_handle = irssi_ssl_get_iochannel(handle, server->connrec->port, server);
if (ssl_handle == NULL)
g_io_channel_unref(handle);

This comment has been minimized.

Copy link
@ailin-nemui

ailin-nemui Jan 17, 2017

Author Contributor

should the channel be unreffd here? I think probably not

This comment has been minimized.

Copy link
@LemonBoy

LemonBoy Jan 22, 2017

Member

Nope, when the call above fails the original handle is left untouched since g_io_channel_unix_get_fd is the only function that operates on the handle parameter of irssi_ssl_get_iochannel before it reaches the function tail where it can't fail anymore.

@ailin-nemui ailin-nemui force-pushed the ailin-nemui:starttls branch from 52c5a61 to 28df637 Feb 5, 2017

@ailin-nemui ailin-nemui merged commit 653c7fb into irssi:master Feb 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui deleted the ailin-nemui:starttls branch Feb 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.