New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenSSL 1.1.0. #628

Merged
merged 1 commit into from Feb 5, 2017

Conversation

Projects
None yet
3 participants
@LemonBoy
Member

LemonBoy commented Jan 23, 2017

  • X509_get_notBefore becomes X509_get0_notBefore
  • X509_get_notAfter becomes X509_get0_notAfter
  • ASN1_STRING_data becomes ASN1_STRING_get0_data (and drops the const)
  • The whole library is now initialized by OPENSSL_init_ssl

Closes #597

Let's give this a spin with LibreSSL too

@LemonBoy

This comment has been minimized.

Member

LemonBoy commented Jan 30, 2017

Tested against libressl-2.5.0 and openssl-1.1.0c, everything is fine and dandy.

@@ -352,13 +363,16 @@ static GIOFuncs irssi_ssl_channel_funcs = {
static gboolean irssi_ssl_init(void)
{
#if (OPENSSL_VERSION_NUMBER >= 0x10100000L) && !defined(LIBRESSL_VERSION_NUMBER)
OPENSSL_init_ssl(0, NULL);

This comment has been minimized.

@ahf

ahf Feb 2, 2017

Member

Is it worth checking the return value here?

This comment has been minimized.

@LemonBoy

LemonBoy Feb 3, 2017

Member

It definitely can't hurt :)

Support OpenSSL 1.1.0.
- X509_get_notBefore becomes X509_get0_notBefore
- X509_get_notAfter becomes X509_get0_notAfter
- ASN1_STRING_data becomes ASN1_STRING_get0_data (and drops the const)
- The whole library is now initialized by OPENSSL_init_ssl

Closes #597

@ailin-nemui ailin-nemui merged commit ff5dd36 into irssi:master Feb 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ailin-nemui ailin-nemui added the 1.0.1 label Mar 3, 2017

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Dec 7, 2017

Merge pull request irssi#628 from LemonBoy/openssl-compat
Support OpenSSL 1.1.0.
(cherry picked from commit ff5dd36)

@ailin-nemui ailin-nemui added this to the 1.0.2 milestone Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment