New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify-ison: Don't send ison before the connection is done #647

Merged
merged 1 commit into from Feb 27, 2017

Conversation

Projects
None yet
2 participants
@dequis
Member

dequis commented Feb 11, 2017

Fixes #596

Alternative fix to #605, this time much more boring and limited in scope.

If anything else relies on the same 120 second wait_cmd delay we can apply this same fix. Relying on the delay isn't great anyway.

@ailin-nemui

This comment has been minimized.

Contributor

ailin-nemui commented Feb 17, 2017

If anything else relies on the same 120 second wait_cmd delay we can apply this same fix. Relying on the delay isn't great anyway.

can you explain this a bit more detailed

@dequis

This comment has been minimized.

Member

dequis commented Feb 17, 2017

It's what I mentioned in #596 (comment)

The fix based on that was #605 and trying to fix it based on that idea resulted in #611. Therefore, that idea is wrong and it's better to do the obvious thing instead.

@ailin-nemui ailin-nemui merged commit fa1a056 into irssi:master Feb 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment