Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dcc get #667

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
2 participants
@ailin-nemui
Copy link
Contributor

commented Mar 7, 2017

fixes #656

fix dcc get
fixes #656

@ailin-nemui ailin-nemui force-pushed the ailin-nemui:fix-dcc-get branch from b220830 to 7bd1b80 Mar 7, 2017

@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2017

we should escape characters, this is a regression of consistently using quotes around file names

@dequis

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

Looks good

Odd but not necessarily bad behavior: if a filename doesn't have spaces but has double quotes, all of these are valid:

/dcc get bob asd"f
/dcc get bob "asd"f"
/dcc get bob 'asd"f'
/dcc get bob "asd\"f"
/dcc get bob 'asd\"f'

But this isn't:

/dcc get bob asd\"f

Also, only the first argument is taken. Given a filename with spaces, asd f, this is valid now:

/dcc get bob "asd f" garbage

garbage is just ignored. But this is invalid:

/dcc get bob asd f

(and it was previously valid which is the feature-regression i keep complaining about and you're probably sick of hearing about by now)

@ailin-nemui ailin-nemui merged commit d57c64a into irssi:master Mar 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ailin-nemui

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2017

thanks, let's do this (for now) then

@ailin-nemui ailin-nemui deleted the ailin-nemui:fix-dcc-get branch Mar 10, 2017

ailin-nemui added a commit to ailin-nemui/irssi that referenced this pull request Dec 7, 2017

Merge pull request irssi#667 from ailin-nemui/fix-dcc-get
fix dcc get

fixes irssi#656
(cherry picked from commit d57c64a)

@ailin-nemui ailin-nemui added this to the 1.0.2 milestone Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.